Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete Links in Monthly Archive #1263

Closed
daemotron opened this issue Apr 27, 2014 · 1 comment
Closed

Incomplete Links in Monthly Archive #1263

daemotron opened this issue Apr 27, 2014 · 1 comment
Assignees
Milestone

Comments

@daemotron
Copy link

When setting CREATE_MONTHLY_ARCHIVE to True , the links on the months' list ("entries from year xxx") to the respective month's index are incomplete. The link to November's archive will look like this:

<a href="11">November</a>

While this works in some webserver environments (since e. g. Apache will by default anticipate missing trailing slashes), it doesn't work in an offline mode. Therefore, the link should look like this:

<a href="11/index.html">November</a>
@Kwpolska Kwpolska self-assigned this Apr 27, 2014
@Kwpolska Kwpolska added this to the v7.0.0 milestone Apr 27, 2014
Kwpolska added a commit that referenced this issue Apr 27, 2014
Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member

Note that running with file:// is not recommended because of JS files.

But this behavior is, in fact, a bug. We should produce paths with /index.html, unless STRIP_INDEXES is True, in which case it should still have a trailing slash anyways.

Fix in #1265.

Kwpolska added a commit that referenced this issue May 1, 2014
fix #1263 -- monthly archive links should end in /index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants