html5.js 404 for IE

[max-arnold]

Got several 404s for html5.js in access.log. The following snippet

    %if use_cdn:
        <!--[if lt IE 9]><script src="//html5shim.googlecode.com/svn/trunk/html5.js"></script><![endif]-->
    %else:
        <!--[if lt IE 9]><script src="/assets/js/html5.js"></script><![endif]-->
    %endif

is expanded as

        <!--[if lt IE 9]><script src="/assets/js/html5.js"></script><![endif]-->

with BASE_URL = "http://example.com/blog/" and USE_CDN = False. Expected path should be http://example.com/blog/assets/js/html5.js.

[da2x]

Out of interest, why aren’t coments processed?

[Kwpolska]

Because why would they be? Usually, HTML comments are supposed to be left in as-is, someone might expect to see an exact thing there. Or, they should be removed. But changing it makes no sense. lxml does not see this as a <script> tag, just a comment containing something that it should not care about in the slightest.

[max-arnold]

Maybe explicit jinja context variable is the way to fix this?

 <!--[if lt IE 9]><script src="{{ BLOG_PREFIX }}/assets/js/html5.js"></script><![endif]-->

[Kwpolska]

We do not have a BLOG_PREFIX variable, we have a link replacement facility though.

https://github.com/getnikola/nikola/blob/master/nikola/nikola.py#L799

With some work, we can make it use that.

[max-arnold]

I can confirm that this patch fixes the issue. Thanks, Chris!