New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenGraph and Twitter card enhancements #1488
Comments
Make the patch into a Pull Request. It looks solid. Documentation is not hard, and we can produce absolute links (though I think we might need to make some changes to |
Should not be needed. Twitter will use OpenGraph when these are not provided. Only thing you achieve is to fatten the |
We can easily create locale codes if we needed some. Does anyone really care about having those tags? Or reading their contents? |
Only if there are no Twitter Card related tags at all, and I haven't tested how they are displayed. Since Nikola has explicit support for Twitter Cards, it is worth adding them. Another option is to drop support completely and rely on OpenGraph only. |
Regarding locale codes, I do not have any strong need to have them right now (just noticed some warnings while using validation tool). |
According to the getting started guide, you can mix og: and twitter: tags. |
I have tested, and whats on master now works with Twitter Cards. |
I did some more testing, and can confirm this too. The problem is that Twitter ignores relative urls for
But final meta tag should be absolute:
Then Twitter validates both |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Is e4cf54c enough? |
There, all done with two issues fixed and two rejected. |
It think it is worth adding one-liner to
|
there, fixed and also revamped the thing a little more. also, the syntax on GitHub is:
|
This was simply copy-pasted as is from the manual, which is in rst format :) |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
It seems that with the current boot4 theme the URL is a relative one again. So now the card on Twitter does not work again, because it cannot find the image. I presume that the theme has to be changed such that it uses the full URL? |
@martin-ueding Cannot reproduce with v8.1.1:
(We recommend to use a path starting with |
I have found the issue! In the |
I also found that this has improved and I am very happy out it! Now everything works just fine. And since the switch to Nikola, I have been blogging so much more 😊. |
After trying new
previewimage
meta tag with Nikola 7.2, I'd like to suggest some improvements.<meta property="og:image">
tag). All examples I've seen always use absolute url and Twitter validation tool fails on relative one.Add support fortwitter:title
,twitter:description
,twitter:image
andtwitter:image:src
tags (for both summary and summary_large_image)There is alsoog:locale
andog:locale:alternate
meta tags which can be used to support multilanguage posts, but I'm not sure it is possible to provide appropriate locale names (Nikola uses 2-letter language codes).Below is the partial patch to add necessary markup (no doc patch, no absolute url patch):
Also there is a tool to validate such markup: http://smo.knowem.com/ It also supports G+ metadata.
The text was updated successfully, but these errors were encountered: