Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links on Windows #1784

Closed
2 tasks done
Kwpolska opened this issue Jun 4, 2015 · 1 comment
Closed
2 tasks done

Broken links on Windows #1784

Kwpolska opened this issue Jun 4, 2015 · 1 comment
Assignees
Milestone

Comments

@Kwpolska
Copy link
Member

Kwpolska commented Jun 4, 2015

  • On AppVeyor:
[2015-06-04T08:34:18Z] WARNING: check: Broken link in output\listings\index.html: https://example.com/foo/listings/index.html.html
  • On my computer: invalid, symlinks issue
[2015-06-04T08:56:23Z] WARNING: check: Broken link in output\index.html: stories/handbook.html
[2015-06-04T08:56:23Z] WARNING: check: Broken link in output\posts\welcome-to-nikola.html: ../stories/handbook.html
@Kwpolska Kwpolska self-assigned this Jun 4, 2015
@Kwpolska Kwpolska added this to the 7.5.0 milestone Jun 4, 2015
@Kwpolska
Copy link
Member Author

Kwpolska commented Jun 4, 2015

<link rel="canonical" href="https://example.com/foo/listings/index.html.html">

This was caused by checking for / instead of os.sep in listings.py, even though we explicitly convert everything to os.sep a few lines above.

Along the way, I found another bug: os.split was used to generate the path parts, even though it makes only one split (and we need all). #1785; cc @felixfontein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant