DEPLOY_DRAFTS and DEPLOY_FUTURE ignored by github_deploy

[ChillarAnand]

FUTURE_IS_NOW = False
DEPLOY_FUTURE = False
DEPLOY_DRAFTS = False

With these settings, drafts with past dates are getting deployed.

[Kwpolska]

Cannot reproduce. Please apply this patch over deploy.py in your Nikola install and show output of nikola deploy:

diff --git a/nikola/plugins/command/deploy.py b/nikola/plugins/command/deploy.py
index 365c0a3..95fbfec 100644
--- a/nikola/plugins/command/deploy.py
+++ b/nikola/plugins/command/deploy.py
@@ -97,9 +97,14 @@ class CommandDeploy(Command):
             for post in self.site.timeline:
                 if (not deploy_drafts and post.is_draft) or \
                    (not deploy_future and post.publish_later):
+                    print("Delete", post, post.is_draft, post.publish_later)
                     remove_file(os.path.join(out_dir, post.destination_path()))
                     remove_file(os.path.join(out_dir, post.source_path))
                     undeployed_posts.append(post)
+                else:
+                    print("Deploy", post, post.is_draft, post.publish_later)
+        else:
+            print("DEPLOY_DRAFTS and DEPLOY_FUTURE are both True")

         if args:
             presets = args

[punchagan]

I suspect os.path.join(out_dir, post.destination_path()) is pointing to a wrong path. Can you also print that?

[punchagan]

The source file path is incorrect, and the following patch should help.

diff --git a/nikola/plugins/command/deploy.py b/nikola/plugins/command/deploy.py
index 365c0a3..1e772c9 100644
--- a/nikola/plugins/command/deploy.py
+++ b/nikola/plugins/command/deploy.py
@@ -98,7 +98,8 @@ class CommandDeploy(Command):
                 if (not deploy_drafts and post.is_draft) or \
                    (not deploy_future and post.publish_later):
                     remove_file(os.path.join(out_dir, post.destination_path()))
-                    remove_file(os.path.join(out_dir, post.source_path))
+                    source_path = post.destination_path(extension=post.source_ext(True))
+                    remove_file(os.path.join(out_dir, source_path))
                     undeployed_posts.append(post)

         if args:

[ChillarAnand]

Output is here https://gist.github.com/anonymous/d8a192cc52ecfeed8011da8c81c472e3

[Kwpolska]

@ChillarAnand could you test @punchagan’s patch and see if it helps in your case?

[ChillarAnand]

My bad. Looks like I overlooked the issue. I was deploying to github pages and ghp-import was commiting even drafts to github. Is there a way to disable this?

[Kwpolska]

Were you using nikola github_deploy? (It does not handle any of these options.)

[ChillarAnand]

Yes, I was using that.