Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment default values in conf.py #2680

Closed
sukiletxe opened this issue Feb 23, 2017 · 4 comments
Closed

Uncomment default values in conf.py #2680

sukiletxe opened this issue Feb 23, 2017 · 4 comments

Comments

@sukiletxe
Copy link
Contributor

Environment (if reporting a bug)

Python Version:

Nikola Version:

Operating System:

Description:

Currently, conf.py contains default options which are commented; that is to say, options which have the same value as the default one, which are commented out. For consistency reason, they should be uncommented.

@Kwpolska
Copy link
Member

Should they really? Sometimes it might be better to upgrade defaults for users. By leaving an option uncommented, you effectively say “I don’t care”.

@Kwpolska Kwpolska added the idea label Feb 23, 2017
@sukiletxe
Copy link
Contributor Author

Well, that's true. Let me explainmyself: The scenario behind my proposal was that I sometimes can't figure out if the commented setting is a default value or a disabled one.

@tritium21
Copy link
Contributor

If the stock conf.py comments out a line, thus disabling a feature, then the default for the feature is disabled. If you, the user, comment out a line, and need a way to note that... its a comment. You can write anything you want after the #

@Kwpolska
Copy link
Member

Let’s leave this as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants