Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reST doc directive: slugs with slashes in no longer work #3450

Closed
infinity0 opened this issue Aug 23, 2020 · 5 comments
Closed

reST doc directive: slugs with slashes in no longer work #3450

infinity0 opened this issue Aug 23, 2020 · 5 comments
Assignees
@Kwpolska
Labels
bug PR exists

Comments

@infinity0
Copy link

At some point in the previous few versions, slugs with slashes in no longer work - links pointing to them have their slashes removed before the link is resolved, leading to an error like "swowndata" slug doesn't exist for a slug called sw/owndata. I can't find this being mentioned in the release notes or the other issues here, so I assume this was done by accident, is a bug, and should be fixed.
@infinity0 infinity0 added the bug label Aug 23, 2020
@Kwpolska
Copy link
Member

Please provide more details. Is this a slug in post meta, or is it a reference with doc or magic links?

@infinity0
Copy link
Author

It's an issue with links - if you nikola build on a checkout of https://github.com/infinity0/droid-hacks you can hopefully reproduce it.

@Kwpolska Kwpolska changed the title slugs with slashes in no longer work reST doc directive: slugs with slashes in no longer work Aug 25, 2020
@Kwpolska
Copy link
Member

Reproduced, bug was introduced in commit 22b2940.

Kwpolska added a commit that referenced this issue Sep 5, 2020
@Kwpolska
Fix #3450 — don’t break slugs with slashes in doc directive
6ba11d5
@Kwpolska Kwpolska mentioned this issue Sep 5, 2020
Merged
@Kwpolska Kwpolska self-assigned this Sep 5, 2020
@Kwpolska
Copy link
Member

Kwpolska commented Sep 5, 2020

I created a PR with a fix, #3455.

Kwpolska added a commit that referenced this issue Sep 5, 2020
@Kwpolska
Fix #3450 — don’t break slugs with slashes in doc directive
0683ae7
@infinity0
Copy link
Author

Thanks, that works nicely for me!

Kwpolska added a commit that referenced this issue Sep 11, 2020
@Kwpolska
Merge pull request #3455 from getnikola/fix-3450
ea1c651 
Fix #3450 — don’t break slugs with slashes in doc directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kwpolska Kwpolska

Labels
bug PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@infinity0 @Kwpolska