Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of pkg_resources with importlib.resources #3743

Closed
1 of 3 tasks
dvzrv opened this issue Jan 16, 2024 · 0 comments · Fixed by #3749
Closed
1 of 3 tasks

Replace use of pkg_resources with importlib.resources #3743

dvzrv opened this issue Jan 16, 2024 · 0 comments · Fixed by #3749

Comments

@dvzrv
Copy link

dvzrv commented Jan 16, 2024

Requested Feature: Since this project only officially supports Python >= 3.7, it is now possible to remove the setuptools dependency with the cpython builtin importlib.resources.

Related Area: dependencies

Do you want to contribute this yourself as a pull request? (don’t worry about it if you don’t want to/can’t — someone else can take care of it)

  • Yes, I have already written code for it (link if available and feasible)
  • Yes, I don’t have code ready yet (that’s okay!)
  • No (that’s okay too!)

Does this feature affect backwards compatibility? If yes, in what way?

As this was introduced in Python 3.7, it should not have any side-effect!

Rationale and full description: (why should it be added to Nikola?)

The pkg_resources API is deprecated and replacing it with a Python internal library is a good approach :)

@Kwpolska Kwpolska linked a pull request Feb 1, 2024 that will close this issue
3 tasks
Kwpolska pushed a commit that referenced this issue Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants