Collapse tags with same slug #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if tag not in self.posts_per_tag: | ||
| # Tags that differ only in case | ||
| other_tag = [k for k in self.posts_per_tag.keys() if k.lower() == tag.lower()][0] | ||
| utils.LOGGER.error('You have cases that differ only in upper/lower case: {0} and {1}'.format(tag, other_tag)) | ||
| utils.LOGGER.error('You have tags that are too similar: {0} and {1}'.format(tag, other_tag)) | ||
| utils.LOGGER.error('Tag {0} is used in: {1}'.format(tag, post.source_path)) |
There was a problem hiding this comment.
Could we make it so we show all the posts that have the tag? Like this:
- keep a list of conflicts internally
- while done, show it at once and exit
Also, how does this work with 3-way conflicts?
There was a problem hiding this comment.
Well, reporting them all at once is a bit harder. I could make it continue so it reports them all and then fail on the repeated target error tho.
3-way conflicts?
There was a problem hiding this comment.
3-way conflicts, as in:
>>> map(nikola.utils.slugify, [u'foo.bar', u'foo,bar', u'foobar'])
['foobar', 'foobar', 'foobar']There was a problem hiding this comment.
If I remove the exit, you get this:
Scanning posts.[2014-02-05T19:40:28Z] ERROR: Nikola: You have tags that are too similar: foo and fOo
[2014-02-05T19:40:28Z] ERROR: Nikola: Tag foo is used in: posts/foo.rst
[2014-02-05T19:40:28Z] ERROR: Nikola: Tag fOo is used in: posts/foo.rst
[2014-02-05T19:40:28Z] ERROR: Nikola: You have tags that are too similar: Foo and fOo
[2014-02-05T19:40:28Z] ERROR: Nikola: Tag Foo is used in: posts/foo.rst
[2014-02-05T19:40:28Z] ERROR: Nikola: Tag fOo is used in: posts/foo.rst
...done!
ERROR: Task generation 'render_site' has duplicated definition of 'render_tags:output/categories/foo.xml'
That's not horrible ;-)
There was a problem hiding this comment.
Though if you want that ugly doit ERROR dead:
utils.LOGGER.error('Tag {0} is used in: {1}'.format(other_tag, ', '.join(self.posts_per_tag[other_tag])))
+quit = 1
⋮
+if quit:
+ sys.exit(1)(define quit = 0 earlier)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1022 by declaring that two tags that generate the same slug is an error.