Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't forget query parts of links #1369

Merged
merged 1 commit into from Jul 24, 2014
Merged

don't forget query parts of links #1369

merged 1 commit into from Jul 24, 2014

Conversation

Kwpolska
Copy link
Member

22:48:11 < Aeyoun> When changing  <link href="/assets/css/all-nocdn.css" rel="stylesheet" type="text/css"> to <link href="/assets/css/all-nocdn.css?experimental" rel="stylesheet" type="text/css"> why does Nikola strip out the query? I can add #fragments and change the path, but not add a query paramter.

We forgot to handle them. This fixes the issue, and works as expected:

<a href="/index.html">/index.html</a>
<a href="/index.html?foo">/index.html?foo</a>
<a href="/index.html#bar">/index.html#bar</a>
<a href="/index.html?foo#bar">/index.html?foo#bar</a>

↓ becomes ↓

<a href="../index.html">/index.html</a>
<a href="../index.html?foo">/index.html?foo</a>
<a href="../index.html#bar">/index.html#bar</a>
<a href="../index.html?foo#bar">/index.html?foo#bar</a>

cc @Aeyoun, @ralsina

Signed-off-by: Chris “Kwpolska” Warrick kwpolska@gmail.com

Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added the bug label Jul 24, 2014
@Kwpolska Kwpolska added this to the v7.0.2 milestone Jul 24, 2014
@da2x
Copy link
Contributor

da2x commented Jul 24, 2014

Thanks! Looks good and I could add ?2 to force browsers to fetch the stylesheet anew if it was cached. :)

Kwpolska added a commit that referenced this pull request Jul 24, 2014
don't forget query parts of links
@Kwpolska Kwpolska merged commit 70eae1d into master Jul 24, 2014
@Kwpolska Kwpolska deleted the query-links branch July 24, 2014 10:18
Kwpolska added a commit that referenced this pull request Jul 24, 2014
[ci skip]

Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants