Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Bootstrap 2 theme #1865

Merged
merged 3 commits into from Jul 5, 2015
Merged

Delete Bootstrap 2 theme #1865

merged 3 commits into from Jul 5, 2015

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 5, 2015

It’s useless and we should not have it around. Can we merge this now, or should this wait for v8?

See also: getnikola/nikola-themes#47

Review on Reviewable

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added the visual label Jul 5, 2015
@Kwpolska Kwpolska added this to the v7.6.1 milestone Jul 5, 2015
Kwpolska added a commit to getnikola/nikola-themes that referenced this issue Jul 5, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska mentioned this pull request Jul 5, 2015
26 tasks
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Jul 5, 2015

Invariance fails, but that’s expected (turns out we had some useless bs2 files in our sites):

Only in /home/travis/build/getnikola/nikola/tests/data/baseline2.7/assets/css: bootstrap-responsive.css  # bs2-only file, merged into bootstrap.css
Only in /home/travis/build/getnikola/nikola/tests/data/baseline2.7/assets/css: bootstrap-responsive.min.css  # bs2-only file, merged into bootstrap.min.css
Only in /home/travis/build/getnikola/nikola/tests/data/baseline2.7/assets: img  # glyphicons were icons and now are fonts

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@ralsina
Copy link
Member

@ralsina ralsina commented Jul 5, 2015

I say let's do this.

ralsina added a commit that referenced this issue Jul 5, 2015
@ralsina ralsina merged commit 9ec5d99 into master Jul 5, 2015
1 of 3 checks passed
@Kwpolska Kwpolska deleted the murder-bootstrap2 branch Jul 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Version 8
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants