Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1938 -- Jupyter compatibility #2178

Merged
merged 2 commits into from Nov 21, 2015
Merged

Fix #1938 -- Jupyter compatibility #2178

merged 2 commits into from Nov 21, 2015

Conversation

@Kwpolska
Copy link
Member

Kwpolska commented Nov 21, 2015

This is #1938. cc @damianavila, @ltiao.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska self-assigned this Nov 21, 2015
@Kwpolska Kwpolska added this to the v7.7.4 milestone Nov 21, 2015
@@ -7,7 +7,7 @@ pygal>=2.0.0
typogrify>=2.0.4
phpserialize>=1.3
webassets>=0.10.1
ipython[notebook]>=2.0.0
jupyter>=1.0.0

This comment has been minimized.

Copy link
@damianavila

damianavila Nov 21, 2015

Member

notebook should be the dependency... jupyter "metapackage" contain a lot of stuff which is not a dependency for the functionality...

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Nov 21, 2015

Author Member

Fixed.

@damianavila
Copy link
Member

damianavila commented Nov 21, 2015

Changes seems ok... I would say that sooner than later we need to deprecate the old API... but let's wait a little bit to do that...

Kwpolska added a commit that referenced this pull request Nov 21, 2015
Fix #1938 -- Jupyter compatibility
@Kwpolska Kwpolska merged commit 00ebeab into master Nov 21, 2015
0 of 4 checks passed
0 of 4 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@Kwpolska Kwpolska deleted the jupyter branch Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.