Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1938 -- Jupyter compatibility #2178

Merged
merged 2 commits into from Nov 21, 2015
Merged

Fix #1938 -- Jupyter compatibility #2178

merged 2 commits into from Nov 21, 2015

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Nov 21, 2015

This is #1938. cc @damianavila, @ltiao.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska self-assigned this Nov 21, 2015
@Kwpolska Kwpolska added this to the v7.7.4 milestone Nov 21, 2015
@@ -7,7 +7,7 @@ pygal>=2.0.0
typogrify>=2.0.4
phpserialize>=1.3
webassets>=0.10.1
ipython[notebook]>=2.0.0
jupyter>=1.0.0
Copy link
Member

@damianavila damianavila Nov 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notebook should be the dependency... jupyter "metapackage" contain a lot of stuff which is not a dependency for the functionality...

Loading

Copy link
Member Author

@Kwpolska Kwpolska Nov 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Loading

@damianavila
Copy link
Member

@damianavila damianavila commented Nov 21, 2015

Changes seems ok... I would say that sooner than later we need to deprecate the old API... but let's wait a little bit to do that...

Loading

Kwpolska added a commit that referenced this issue Nov 21, 2015
@Kwpolska Kwpolska merged commit 00ebeab into master Nov 21, 2015
0 of 4 checks passed
Loading
@Kwpolska Kwpolska deleted the jupyter branch Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants