Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a title has line breaks it messes up meta generation. #2330

Merged
merged 2 commits into from May 1, 2016

Conversation

Projects
None yet
2 participants
@dmwyatt
Copy link
Contributor

commented May 1, 2016

No description provided.

# titles can have line breaks in them, particularly when they are
# created by third-party tools that post to Wordpress.
# Handle windows-style and unix-style line endings.
title = title.replace('\r\n', ' ').replace('\n')

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska May 1, 2016

Member

missing the second argument to str.replace in the second call

@Kwpolska Kwpolska merged commit 81f0e3b into getnikola:master May 1, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kwpolska

This comment has been minimized.

Copy link
Member

commented May 1, 2016

Thanks for your contribution!

@Kwpolska Kwpolska added this to the v7.7.9 milestone May 1, 2016

@Kwpolska Kwpolska self-assigned this May 1, 2016

Kwpolska added a commit that referenced this pull request May 4, 2016

Changelog for #2330
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.