Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to override url_type in render_template and rewrite_links methods. #2517

Merged
merged 1 commit into from Oct 2, 2016

Conversation

@felixfontein
Copy link
Contributor

felixfontein commented Oct 2, 2016

This allows a plugin to render a page which can be put at various URLs even if URL_TYPE in the site's config is set to rel_path. This can for example be used for creating 404 pages.

Copy link
Member

Kwpolska left a comment

LGTM, will you publish the error pages plugin anywhere?

@felixfontein
Copy link
Contributor Author

felixfontein commented Oct 2, 2016

As soon as I've implemented it, yes ;) I'm just in the process of checking what I need for it.

@Kwpolska Kwpolska merged commit 65d1832 into master Oct 2, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the improving-link-rewrite-interface branch Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.