Experiments for generalization of taxonomies.

[felixfontein]

This is about #2107. I added a new plugin category, Taxonomy, as well as two plugins which take care to classify posts with all Taxonomy plugins and render all associated pages for them.

The next step is re-implementing the following plugins with this framework and see if it works:

• archive
• authors
• indexes (needs to be split up into two plugins, one for the main index and one for section indexes)

It's not possible to recreate the tags plugin with this framework as it contains the option (which is even default!) to put tags and categories onto the same overview page. But that problem will be solved in v8 anyway when categories go away :)

[Kwpolska]

Do we have any use case for minimum_post_count_per_classification_in_overview and omit_empty_classifications?

[felixfontein]

minimum_post_count_per_classification_in_overview will be site.config['TAGLIST_MINIMUM_POSTS'] for tags.

omit_empty_classifications allows to prevent some collisions if you have also_create_classifications_from_other_languages enabled (which seems to be the default for tags and categories in the current implementation).

[Kwpolska]

Add a note about this and sort_classifications being in-place.

[felixfontein]

I adjusted that.

[Kwpolska]

utils.TreeNode (which I haven’t known about before)

[felixfontein]

I think I introduced them for category hierarchies.

[Kwpolska]

There are lots of features I never used, and category hierarchies are one of them.

[ralsina]

@felixfontein don't worry much about codacy, I was just curious about how it worked. It finds interesting stuff, tho!

[felixfontein]

It did find some unused imports flake8 didn't find. And renaming type to something else might be good, too, as type has a special meaning in Python. So it did make sense to fix these things ;)

[Kwpolska]

@felixfontein Is this mergeable?

[felixfontein]

Yes, I think so. From my side the branch is complete. The result should get a bit more testing with some more real-life blogs before a new version of Nikola is released, though. I've tested it with my blogs and with yours, but that doesn't cover all edge cases :)

[felixfontein]

@ralsina: now codacy also found some more interesting bugs (see e775b0f). It looks like it's a useful extension to flake8.

[Kwpolska]

Codacy isn’t some magic. That’s just pylint as a service, which has been configured to be less nitpicky.

[felixfontein]

Should we merge? Or wait some more?

[Kwpolska]

Please test with nikola-site first. And if you have some spare time, try to increase test coverage of the new features (if you don’t, we’ll merge now).

[felixfontein]

nikola-site now works. I don't really have time now to add more tests; anyway, almost all of the things which might break are related to existing features which were never tested.

[Kwpolska]

Merging then. Thanks for all the effort you put in this PR!

[felixfontein]

Thanks for all the feedback and merging!

[Kwpolska]

Here’s an issue, detected with nikola-logs: render_Indexes in DISABLED_PLUGINS won’t work anymore. I had to set INDEX_PATH to something else.

[Kwpolska]

Uh, that won’t cut it. I had to disable render_taxonomies entirely, or otherwise I’d get a wasteful blog folder (that site uses posts, not pages, and has custom post_list indexes). See #2581.

[felixfontein]

The plugin's name is now classify_indexes, as it doesn't do rendering anymore.

[Kwpolska]

May I request to restore the old names? That way, we won’t break backwards compatibility with existing blogs.

[felixfontein]

That doesn't work because there is no 1:1 mapping between old and new names.

I could add some hack which detects the old names in DISABLED_PLUGINS and inserts the corresponding new ones and informs the user.

[Kwpolska]

👍 for that (let’s move the discussion to #2581).