Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin deps (Fix #2533) #2541

Merged
merged 5 commits into from Oct 20, 2016
Merged

Plugin deps (Fix #2533) #2541

merged 5 commits into from Oct 20, 2016

Conversation

@ralsina
Copy link
Member

ralsina commented Oct 19, 2016

This fixes #2533

ralsina added 3 commits Oct 19, 2016

req_plug_path = os.path.join(dest_path, 'requirements-plugins.txt')
if os.path.exists(req_plug_path):
LOGGER.notice('This plugin requires other nikola plugins.')

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Oct 19, 2016

Member

Nikola*

try:
with io.open(req_plug_path, 'r', encoding='utf-8') as inf:
for plugname in inf.readlines():
subprocess.check_call((sys.executable, '-m', 'nikola', 'plugin', '-i', reqpath))

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Oct 19, 2016

Member

Can’t we just call do_install here?

This comment has been minimized.

Copy link
@ralsina

ralsina Oct 20, 2016

Author Member

Maybe.

ralsina added 2 commits Oct 20, 2016
doh
@Kwpolska Kwpolska merged commit 5ee1a3a into master Oct 20, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the plugin-deps branch Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.