New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pages index #2701

Merged
merged 5 commits into from Mar 26, 2017

Conversation

Projects
None yet
2 participants
@felixfontein
Contributor

felixfontein commented Mar 24, 2017

Fixes remaining issue in #2646 and makes the pages index plugin actually work.

@Kwpolska

This comment has been minimized.

Show comment
Hide comment
@Kwpolska

Kwpolska Mar 25, 2017

Member

Doesn’t work yet:

<article class="listpage"><header><h1>Demo Site</h1>
    </header><p>Nothing found.</p>
</article>

I’ll try to debug myself.

Member

Kwpolska commented Mar 25, 2017

Doesn’t work yet:

<article class="listpage"><header><h1>Demo Site</h1>
    </header><p>Nothing found.</p>
</article>

I’ll try to debug myself.

Kwpolska added some commits Mar 25, 2017

Fix #2646 -- make page indexes actually work
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@Kwpolska Kwpolska requested a review from ralsina Mar 25, 2017

@Kwpolska

This comment has been minimized.

Show comment
Hide comment
@Kwpolska

Kwpolska Mar 25, 2017

Member

I had to add some special casing for list.tmpl, because this is what page indexes wanted. Merging and releasing v7.8.4 if no-one objects.

Member

Kwpolska commented Mar 25, 2017

I had to add some special casing for list.tmpl, because this is what page indexes wanted. Merging and releasing v7.8.4 if no-one objects.

@felixfontein

This comment has been minimized.

Show comment
Hide comment
@felixfontein

felixfontein Mar 25, 2017

Contributor

Thanks for fixing this! I just checked whether index.html was created without errors, but forgot to check whether it actually has content...

Contributor

felixfontein commented Mar 25, 2017

Thanks for fixing this! I just checked whether index.html was created without errors, but forgot to check whether it actually has content...

Do classify pages, but don’t classify hidden posts
cc @felixfontein

Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@Kwpolska Kwpolska merged commit ef4ecc7 into master Mar 26, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Kwpolska Kwpolska deleted the fixing-pages-index branch Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment