Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cleanup of 'terminado' and 'tornado' #2872

Merged
merged 2 commits into from Jul 17, 2017

Conversation

@uli-heller
Copy link
Contributor

@uli-heller uli-heller commented Jul 17, 2017

After creating the snap, these are directories containing files. So you
cannot delete them via 'rm'

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

Without this change, you'll get an error message towards the end of the
creation of the snap. Unfortunately, I don't have a copy of it available at the moment.
I can recreate it when required.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 17, 2017

This is a minor change, not worthy of a changelog entry. Most users don’t care about building snaps.

@uli-heller
Copy link
Contributor Author

@uli-heller uli-heller commented Jul 17, 2017

uli-heller added 2 commits Jul 17, 2017
After creating the snap, these are directories containing files. So you
cannot delete them via 'rm'
@uli-heller uli-heller force-pushed the uli-heller:fix-snap-rmrf branch from 33b70f5 to 2529877 Jul 17, 2017
@uli-heller
Copy link
Contributor Author

@uli-heller uli-heller commented Jul 17, 2017

I've updated the PR, no more changes to CHANGES.txt

@ralsina ralsina merged commit d729c21 into getnikola:master Jul 17, 2017
3 checks passed
3 checks passed
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 17, 2017

Using xargs like that can be unsafe (if you have spaces in directory names), I fixed it in 37eb408.

uli-heller added a commit to uli-heller/nikola that referenced this pull request Jul 19, 2017
* Fixed cleanup of 'terminado' and 'tornado'
After creating the snap, these are directories containing files. So you
cannot delete them via 'rm'

* 'snapcraft clean nikola -s pull;snapcraft' produced an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants