Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing shortcode #2880

Merged
merged 6 commits into from Jul 27, 2017
Merged

Listing shortcode #2880

merged 6 commits into from Jul 27, 2017

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Jul 24, 2017

Implement #2868

Copy link
Member

@Kwpolska Kwpolska left a comment

What’s up with the license? Could we avoid duplicating rest/listings.py code?

@@ -0,0 +1,58 @@
# -*- coding: utf-8 -*-
# This file is public domain according to its author, Brian Hsu

This comment has been minimized.

This comment has been minimized.

@ralsina

ralsina Jul 26, 2017
Author Member

Whoa, flashback. I don't think any of that code is still there. OTOH, I suspect this is because I copied gist.py :-)

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 27, 2017

Could we avoid duplicating rest/listings.py code?

@ralsina
Copy link
Member Author

@ralsina ralsina commented Jul 27, 2017

@Kwpolska there is not that much repeated code:

  • The code to find the original file
  • The code to generate the link to the sources

It's about 10 LOC and only used in these two, so can't go to utils/ ... any suggestions where I could put it?

@Kwpolska Kwpolska merged commit a90d068 into master Jul 27, 2017
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Kwpolska added a commit that referenced this pull request Jul 27, 2017
@Kwpolska Kwpolska deleted the listing-shortcode branch Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants