Fix some deprecation warnings generated during the test suite #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning was triggered many times during test suite,
and read:
nikola/image_processing.py:148: DeprecationWarning: ANTIALIAS is
deprecated and will be removed in Pillow 10 (2023-07-01). Use LANCZOS or
Resampling.LANCZOS instead.
im.thumbnail(size, Image.ANTIALIAS)
The warning was triggered during test suite, and read:
nikola/plugins/compile/rest/__init__.py:80: PendingDeprecationWarning:
nodes.Node.traverse() is obsoleted by Node.findall().
for docinfo in document.traverse(docutils.nodes.docinfo):
tartley
changed the title
tartley
changed the title
Kwpolska
reviewed
Mar 26, 2023
.gitignore
Outdated
| @@ -5,6 +5,7 @@ | |||
| tmp/ | |||
| cache/ | |||
| output/ | |||
| tags | |||
There was a problem hiding this comment.
Is this a file or a directory? Is it placed in the repository root (then it should be /tags) or in some other static location?
There was a problem hiding this comment.
Ah, of course, silly me. Thank you for helping me get it right.
Kwpolska
approved these changes
Mar 26, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
I added a trivial item to .gitignore. The 'tags' file is produced by utilities like 'ctags' (incl. the venerable exhuberant-ctags, and the modern universal-ctags), and is used by programs like Vim for 'go to definition' functionality.
I fixed two deprecation warnings that were generated when I ran the test suite, by making the substitutions suggested by the deprecation warnings themselves. Tests still pass, and the relevant functionality (RST to HTML and antialiasing in thumbnails) still seems to work in a freshly-built site.
The test suite does still generate two deprecation warnings, but they are from code in a dependency of ours (yapsy), and we are using the latest version of that.