Obvious (provisorical) fix to lxml dependency incompatibility problem. #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # remove when the lxml 5.x.y compatibility has been re-established | ||
| # via https://github.com/getnikola/nikola/issues/3732 | ||
| lxml>=4.9.4,<5.0.0 |
There was a problem hiding this comment.
Any reason why versions from 3.3.5 to 4.9.3 are not OK?
There was a problem hiding this comment.
I didn't test that, so I cannot answer that question.
There was a problem hiding this comment.
For philosophy:
- Nikola's tests only ever test against the latest versions of all dependencies.
- I cringe at promising functionality for which there are no tests whatsoever.
There was a problem hiding this comment.
Version 5.0.1 worked fine: https://github.com/getnikola/nikola/actions/runs/7438297625/job/20236910255#step:5:33
There was a problem hiding this comment.
Line 9 of the file you edited says lxml>=3.3.5.
|
Superseded by #3735 (which introduced a workaround for the lxml bug). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
For now, pin the lxml version to the last 4.x.y to maintain compatibility with existing code.
This is a band-aid. No root cause analysis of the incompatibility has been made yet.
This pertains to, but does not yet solve, #3732.