from pkg_resources to importlib_resources #3748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fondbcn please check out your PR's changes. You added a LOT of files to this PR that don't belong here. Please rebase your PR to remove these files. |
Kwpolska
requested changes
Jan 23, 2024
nikola/nikola.py
Outdated
| @@ -1031,7 +1031,7 @@ def init_plugins(self, commands_only=False, load_all=False): | |||
| extra_plugins_dirs = self.config['EXTRA_PLUGINS_DIRS'] | |||
| self._loading_commands_only = commands_only | |||
| self._plugin_places = [ | |||
| resource_filename('nikola', 'plugins'), | |||
| importlib_resources('nikola') / 'plugins', | |||
There was a problem hiding this comment.
- You can’t call a module like that, this code couldn’t have worked.
- We want to use the standard library
importlib.resources.
|
Sorry for that, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Trying to replace the old pkg_resources with importlib_resources