Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable Read More #574

Merged
merged 3 commits into from Aug 10, 2013
Merged

Customizable Read More #574

merged 3 commits into from Aug 10, 2013

Conversation

Kwpolska
Copy link
Member

#412 part 2: Electric Boogaloo.

Do not pull yet. I’m putting a pull request for various reasons, like Travis tests.

@Kwpolska
changelog entry
3323f3f 
Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
@Kwpolska
initial read more code, a bit hacky
3493003 
Now entering extensive testing mode.

Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
@ghost ghost assigned Kwpolska Aug 10, 2013
@Kwpolska
Copy link
Member Author

@ralsina, please review.

@Kwpolska
Customizable Read More! also adding a .more class.
91b1a72 
(warning: default value requires UTF-8 or any other encoding that includes
 … U+2026 HORIZONTAL ELLIPSIS)

Fixes #412, fixes #533.

Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
@damianavila
Copy link
Member

Travis is green now...

OK, the code looks good,
One question: do you have plans to make changes in the templates css to incorporate a default value to the .more class?

@Kwpolska
Copy link
Member Author

I’m staying with the status quo right now, and I did not make any styles.

@Kwpolska
Copy link
Member Author

I called this hacky, what do y’all think about it?

@damianavila
Copy link
Member

I’m staying with the status quo right now, and I did not make any styles.

OK, fair enough... ;-)

I called this hacky, what do y’all think about it?

Not enough hacky to me ;-)

👍 for me to this one... let @ralsina say something before merging

@ralsina
Copy link
Member

ralsina commented Aug 10, 2013

Looks good to me!

@damianavila
Copy link
Member

OK, merging...

damianavila added a commit that referenced this pull request Aug 10, 2013
@damianavila
Merge pull request #574 from Kwpolska/customizable-read-more
6f74b29 
Customizable Read More
@damianavila damianavila merged commit 6f74b29 into getnikola:master Aug 10, 2013
@Kwpolska Kwpolska deleted the customizable-read-more branch August 10, 2013 16:08
@Kwpolska Kwpolska mentioned this pull request Apr 10, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kwpolska Kwpolska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kwpolska @damianavila @ralsina