Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to add additional metadata to all new posts #622

Merged
merged 1 commit into from Aug 27, 2013
Merged

Config option to add additional metadata to all new posts #622

merged 1 commit into from Aug 27, 2013

Conversation

punchagan
Copy link
Member

No description provided.

@Kwpolska
Copy link
Member

looks good! Merging right in.

Kwpolska added a commit that referenced this pull request Aug 27, 2013
Config option to add additional metadata to all new posts
@Kwpolska Kwpolska merged commit d889760 into getnikola:master Aug 27, 2013
Kwpolska added a commit that referenced this pull request Aug 27, 2013
@punchagan
Copy link
Member Author

Thanks!

@punchagan punchagan deleted the additional-metadata branch August 27, 2013 16:34
@punchagan
Copy link
Member Author

@ralsina @Kwpolska Is it recommended to update the changelog with every pull request? Or is it better to leave those changes for the maintainers?

@ralsina
Copy link
Member

ralsina commented Aug 27, 2013

@punchagan I prefer if you add things to the changelog in the PR itself.

BTW, how does this work if you have conflicting metadata specified in a post?

@punchagan
Copy link
Member Author

@ralsina, OK will keep in mind for future PRs.

The additional metadata is added to the post, when the post file is being created. The post doesn't "exist" yet, to be able to specify conflicting metadata. But, the ADDITIONAL_METADATA can have values like title or date, and in that case, creating the new post will fail with an error TypeError: create_post() got multiple values for keyword argument 'title'.

@ralsina
Copy link
Member

ralsina commented Aug 27, 2013

On 27/08/13 14:21, Puneeth Chaganti wrote:

@ralsina https://github.com/ralsina, OK will keep in mind for future
PRs.

The additional metadata is added to the post, when the post file is
being created. The post doesn't "exist" yet, to be able to specify
conflicting metadata. But, the |ADDITIONAL_METADATA| can have values
like |title| or |date|, and in that case, creating the new post will
fail with an error |TypeError: create_post() got multiple values for
keyword argument 'title'|.

Oh, I thought it was meant to add extra data to existing posts as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants