Sitemap fixes #864
Merged
Sitemap fixes #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files such as alexa-verify, google-site-verification, etc. Generated files all have doctype declerations, and they are required for standards mode in browsers. Use real_path directly instead of recreating it as filepath.
|
Not thrilled about the doctype test... sites may include some random old html files without one. |
|
I didn’t really find any better solution. Doctypes are required by browsers and the spec alike. The only once I have without them are the weird domain ownership verifications from various third-parties. Samples of files I am trying to target: |
|
@ralsina, I’d like to merge this as-is unless you strongly object to it. |
|
On 22/10/13 17:57, Daniel Aleksandersen wrote:
Go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.