Config Base and Legacy #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamcosta
requested review from
wbotelhos,
iondrimba,
eduardojmatos,
GeorgeJegon and
felipeorlando
| @@ -1,4 +1,7 @@ | |||
| # eslint-config-getninjas | |||
|
|
|||
| [](https://badge.fury.io/js/eslint-config-getninjas) | |||
index.js
Outdated
| @@ -1,41 +1,11 @@ | |||
| module.exports = { | |||
| extends: 'airbnb-base', | |||
|
|
|||
| parser: 'babel-eslint', | |||
There was a problem hiding this comment.
Is this config no more necessary?
There was a problem hiding this comment.
This config is in common.js file.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, In fact I was also in doubt about leaving this config in common. Because in my view the ES5 does not need babel.
There was a problem hiding this comment.
The parser config option isn't on common.js file. You can just add this there...
iondrimba
reviewed
Oct 20, 2017
| @@ -0,0 +1,32 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
Congrats, very professional @williamcosta @nathpaiva 🙏
iondrimba
reviewed
Oct 20, 2017
| }], | ||
| 'class-methods-use-this': ['off', {}] | ||
| }, | ||
| }; |
iondrimba
approved these changes
Oct 20, 2017
felipeorlando
suggested changes
Oct 23, 2017
index.js
Outdated
| @@ -1,41 +1,11 @@ | |||
| module.exports = { | |||
| extends: 'airbnb-base', | |||
|
|
|||
| parser: 'babel-eslint', | |||
There was a problem hiding this comment.
The parser config option isn't on common.js file. You can just add this there...
|
@felipeorlando @iondrimba e @eduardojmatos ontem fiz uns ajustes aqui. |
felipeorlando
approved these changes
Oct 24, 2017
eduardojmatos
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new config for legacy project to support es5 and es6:
airbnb-base/legacyjasmine-jqueryto support tests with DOM