Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Build shows label instead of constraint message #36

Closed
yanokwa opened this issue Mar 18, 2014 · 6 comments
Closed

Build shows label instead of constraint message #36

yanokwa opened this issue Mar 18, 2014 · 6 comments

Comments

@yanokwa
Copy link
Member

yanokwa commented Mar 18, 2014

From mobinul@mpower-health.com

I was working on modification in ODK buid since past few months. There was a bug, which is it shows the label instead of constraint message.

The problem was in https://github.com/clint-tseng/odkbuild/blob/master/public/javascripts/data.js

LIne 436. There was
addTranslation(control.label, xpath + control.name + ':constraintMsg', translations);

It should be
addTranslation(control.invalidText, xpath + control.name + ':constraintMsg', translations);

@yanokwa yanokwa closed this as completed Mar 18, 2014
@yanokwa yanokwa reopened this Mar 18, 2014
@issa-tseng
Copy link
Member

Does someone want to make this as a pull request to get credit, or should I just go ahead and drop that in?

@yanokwa
Copy link
Member Author

yanokwa commented Mar 18, 2014

I'd wait for a few days. If the dude doesn't respond, then drop it in.

@Mobinul
Copy link

Mobinul commented Mar 19, 2014

Can you permit me to push my update in git repository?

@issa-tseng
Copy link
Member

Please create a pull request: https://help.github.com/articles/using-pull-requests

@dayalpuri
Copy link

Hi, I think the bug is still there (or it is similar). In Numeric type of question you specify range and add text to Invalid Text message. In the questionnaire it displays question label instead. And again problem is in translating to xml, becuase in odkbuildfile it is correct.

@yanokwa
Copy link
Member Author

yanokwa commented Sep 11, 2014

Confirmed that this is still an issue. @clint-tseng can you fix and deploy?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants