Return specific Problem if form version in submission XML is not found

[matthew-white]

From the forum: https://forum.getodk.org/t/central-api-docs-example-submission-xml-issue/39139

If you send submission XML whose version attribute does not match any version of the form, then Backend returns a 404.1 Problem ("Could not find the resource you were looking for."):

central-backend/lib/resources/submissions.js

Lines 123 to 127 in a2ca89a

	// default per-project submission path:
	openRosaSubmission('/projects/:projectId/submission', false, (auth, { projectId }, xmlFormId, Forms, version) =>
	Forms.getByProjectAndXmlFormId(projectId, xmlFormId, false, version)
	.then(getOrNotFound)
	.then(ensureDef)

central-backend/lib/resources/submissions.js

Lines 209 to 212 in a2ca89a

	restSubmission('/projects/:projectId/forms/:formId', false, ({ projectId, formId }, Forms, version) =>
	Forms.getByProjectAndXmlFormId(projectId, formId, false, version) // TODO: okay so this is exactly the same as the func above..
	.then(getOrNotFound)
	.then(ensureDef)

However, especially if the user doesn't know about the version attribute or that Backend is searching on it, they might not understand why they're receiving a 404 response and might not know how to proceed. (The user might wonder: Does the URL not match a current endpoint? Is the project ID wrong? The form ID?) I think I've gotten confused around this myself after forgetting to specify the version attribute.

I think it'd be useful to return a specific 404 Problem in this case. I think it'd be useful for the Problem to indicate the project ID + xmlFormId + form version string that Backend is looking for. The forum post mentions the REST endpoint specifically, but I think it'd be useful to update both the REST and OpenRosa endpoints.

CC @lindsay-stevens

[ktuite]

Having run into this issue doing various dev work and not knowing/forgetting this was a thing, I support this change!

[matthew-white]

This came up on the forum again here: https://forum.getodk.org/t/openrosa-api-for-posting-a-submission-not-working/40259