Geolocation data are lost after changing device orientation while filling answer

[mmarciniak90]

Software and hardware versions

Collect v1.15

Problem description

Geolocation data are lost after changing device orientation while filling answer

Steps to reproduce the problem

1. The user starts one of Geo Widget: GeoShape, GeoTrace, GeoPoint
2. The user adds location, depend on question

3. The user changes device orientation. 4. The user needs to fill location again because all data were lost.

Expected behavior

Changing the orientation of the device does not cause loss of geolocation data

[SaumiaSinghal]

It seems changing device orientation is causing a lot of issues here, because i worked on a similiar issue earlier, @mmarciniak90, I'd like to work on this one too. Maybe if i dig a little more deeper, i can come up with a better solution for that issue as well.

[SaumiaSinghal]

@opendatakit-bot claim

[lognaturel]

Thanks for filing, @mmarciniak90! This is starting to veer into issues discussed in https://forum.opendatakit.org/t/collect-geotrace-and-geoshape-improvements/10160 and in the summary at https://docs.google.com/document/d/1r3wJrOVDeFQkk4kWMoW29LtLI1vbBChqJ65w1Jyg4YU/edit. I haven't been so sure how to track these issues at the repo level because they're fairly tightly coupled. Fundamentally, we want to use the various bugs and limitations that exist in the geo widgets to guide a refactor that will make them less buggy, more harmonized and generally easier to maintain and evolve.

That work has had some false starts but @zestyping who was part of the team that initially proposed and addressed many of them has taken it up again. I think we should probably hold off on other changes to geo for now to minimize conflicts.

[SaumiaSinghal]

Oh okay @lognaturel, just inform me when i can start working on this issue.

[getodk-bot]

Hello @SaumiaSinghal, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 5 days.

If you've decided to work on something else, simply comment @opendatakit-bot unclaim so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Open Data Kit!

[lognaturel]

Some additional notes in #2145.

[zestyping]

#2640 fixes this problem for GeoTraceActivity and GeoShapeActivity.

This issue is remaining open because the GeoPoint activities still need to be fixed.

[zestyping]

#2806 fixes this problem for GeoPointMapActivity.

That's all of them, so we can close this issue now.

[zestyping]

@yanokwa I think we can close this issue now.

[yanokwa]

Fixed by #2806