Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI is out of sync with selection in Send Finalized Form after submission failure #3866

Open
lognaturel opened this issue May 25, 2020 · 4 comments
Labels
bug help wanted Issues that are well-specified and don't require too much context. user experience

Comments

@lognaturel
Copy link
Member

Software and hardware versions

Collect v1.27.0

Problem description

UI is out of sync with selection in Send Finalized Form after submission failure.

Steps to reproduce the problem

  1. Select a form that will fail to send
  2. Send it
  3. See that it is still selected but if you try to send again, you get an error saying nothing is selected

Expected behavior

The UI should update to match the selection state.

@lognaturel lognaturel added bug good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) user experience labels May 25, 2020
@mmarciniak90
Copy link
Contributor

@lognaturel is it possible that this issue is related to the Android version? Or maybe some extra conditions need to be met. Maybe the cause of failure is important.
I'm not able to reproduce this on Android: 6.0, 7.0, 8.1, 9.0
I try to send form which is not available on Aggregate.

@lognaturel lognaturel added needs reproduction and removed good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) labels May 26, 2020
@lognaturel
Copy link
Member Author

lognaturel commented May 26, 2020

Huh! That is really strange and I guess it explains why you've never run into it. 🙃 I'm on Android 7.0 but can't really think of how it would be related to Android version. I'll try to get a reproduction on a sandbox server. If you haven't been able to reproduce it's not very important.

@mmarciniak90
Copy link
Contributor

mmarciniak90 commented Mar 23, 2021

Yeah! Finally, we were able to reproduce this issue. It seems that different causes of failure give different results on Android versions. Here are some examples.

CASE 1 :

  1. Form downloaded from the default demo server
  2. I edited the server URL
  3. I sent form -> issue wasn't visible, I tried sent again -> issue visible on Android 7, 8.1, 10
  4. I reopened the Send Finalized Form view and tried again -> issue visible only on Android 10, second try also caused it on Android 7 and 8

CASE 2:

  1. Form downloaded from the default demo server
  2. I edited the server URL to Aggregate
  3. I sent form -> issue wasn't visible, I tried sent again -> issue was visible only on Android 7
  4. I reopened the Send Finalized Form view and tried again -> issue was visible only on Android 7

CASE 3:

  1. Form downloaded from the default demo server
  2. I scanned the Central QR code where this form was not available
  3. I sent form -> issue was visible only on Android 10 -> I tried again on Android 7 and 8 and then the issue was visible

@kkrawczyk123
Copy link
Contributor

I was able to reproduce the issue on all my Android devices, there are my results:

  • When I input in the URL my local aggregate with the wrong port number. On Android 9 it was visible in my first try but on 7.1 and 5.1 in the second try (after the first one form was not selected after failed sending).
    the error message that I have seen:
    Screenshot_20210323-123916

  • I was also able to reproduce it with the wrong URL of Central when input random letter in URL but not in // with project number. Here I was able to reproduce it only in the second try on all devices.
    the error message that I have seen:
    Screenshot_20210323-124026

  • I was also able to reproduce when I downloaded form from Central demo server and tried to send a submission to aggregate where this form does not exist. On Android 9 in the first try but on 7.1 and 5.1 in the second try. I obtained the same error message that @mmarciniak90 in Case 2.

One more interesting fact is that form selection after failed sending disappears after screen rotation.

@lognaturel lognaturel added help wanted Issues that are well-specified and don't require too much context. and removed needs reproduction labels Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Issues that are well-specified and don't require too much context. user experience
Projects
None yet
Development

No branches or pull requests

3 participants