After using Save icon in form with background recording, recording is not saved

[kkrawczyk123]

Software and hardware versions

Collect v1.29.x, Android vx.x.x, device used...

Problem description

When testing #4392 I have noticed that the behavior of save using save icon and save on dialog differs. When save on dialog recording is saved but when save using icon and then leave form ignoring further changes recording is not saved. It might be confusing.

Steps to reproduce the problem

1. Open form with background recording
2. Click on Save icon in form
3. Use back button
4. Ignore changes on displayed dialog
5. Open files - instance is saved but recording is ignored.
   

Expected behavior

The recording should not be ignored, it should be saved like after saving on save/ignore changes dialog.

Other information

Things you tried, stack traces, related issues, suggestions on how to fix it...

[lognaturel]

Thanks, this is a good one. I doubt it's very common that folks are saving, making changes, and then deciding to discard just those changes but it probably does happen and losing a background recording in that case is definitely unexpected. I think we should consider treating the in-form save as the end of one form-filling session and the start of another so that background audio would be saved and possibly stitched together.