Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong settings file path #456

Closed
grzesiek2010 opened this issue Feb 23, 2017 · 2 comments
Closed

Wrong settings file path #456

grzesiek2010 opened this issue Feb 23, 2017 · 2 comments

Comments

@grzesiek2010
Copy link
Member

Software and hardware versions

Collect v1.4.16

Problem description

When user saves settings to file this file is stored in odk/settings/collect.settings but then we try to load this file form odk/collect.settings and the file is not found of course. https://github.com/opendatakit/collect/blob/master/collect_app/src/main/java/org/odk/collect/android/activities/MainMenuActivity.java#L133

Other information

We should try to load the file from odk/settings/collect.settings not from odk/collect.settings

@lognaturel
Copy link
Member

This is actually the intended behavior -- saving and loading settings are done from separate locations. This is because when you save settings, you're not saving them for this device but for some other one or mass configuration, etc. We don't want to load and delete those saved settings on next app launch.

That said, this is not very intuitive or well-documented. We should give some thought to how this can be made clearer.

@lognaturel
Copy link
Member

Let's track at getodk/docs#5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants