Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchy view styling #5837

Closed
alyblenkin opened this issue Nov 14, 2023 · 4 comments · Fixed by #5885
Closed

Hierarchy view styling #5837

alyblenkin opened this issue Nov 14, 2023 · 4 comments · Fixed by #5885
Assignees
Milestone

Comments

@alyblenkin
Copy link
Collaborator

alyblenkin commented Nov 14, 2023

Problem:
The hierarchy view styling differs from the form entry experience, so they don't look connected and can create a confusing user experience.

Solution:
Unify the hierarchy view by matching the styling from the form entry

  • Padding
  • Font size and weight for question and answer
  • Indent the answer in the hierarchy view
  • Adding a folder icon to match the table of contents

Figma

Considerations for design pairing:
The form entry uses a bold font for the question, which works well for short questions. However, long bold questions are challenging to read. If we have time, I think we should explore using a medium weight for hierarchy and form entry questions to see how that changes readability.

@alyblenkin alyblenkin added this to the v2023.4 milestone Nov 14, 2023
@alyblenkin
Copy link
Collaborator Author

alyblenkin commented Nov 14, 2023

@seadowg I was thinking about your feedback about the group name, and I explored adding a folder icon to better distinguish between the group and questions. Curious to know what you all think @lognaturel

Image

@lognaturel
Copy link
Member

I like it in the table of contents because it matches the group listing! I'm not loving it within form entry, though because it adds a whole new concept.

@alyblenkin
Copy link
Collaborator Author

I like it in the table of contents because it matches the group listing! I'm not loving it within form entry, though because it adds a whole new concept.

I was trying to make it consistent, but it would be introducing something new, and it could be distracting within the form entry.

@seadowg
Copy link
Member

seadowg commented Nov 15, 2023

I like it in the table of contents because it matches the group listing! I'm not loving it within form entry, though because it adds a whole new concept.

Yeah totally agreed. It's definitely nice that it's consistent, but I think it's probably safer to avoid it in form entry given how much can be on screen already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

4 participants