Fixed issues caused by the new 'masked' appearance #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
changed the title
grzesiek2010
force-pushed
the
COLLECT-6073
branch
from
1019a5e
to
6628186
Compare
grzesiek2010
changed the title
seadowg
requested changes
Apr 15, 2024
There was a problem hiding this comment.
This pull request addresses three issues but only #6072 is worth explaining. To me, it seems like an Android bug since only number questions were affected. It looks like moving the cursor needs to be delayed a little bit so I used the post method like in a few other places of the app.
These no post in the changes. Is there a commit missing perhaps? Or I guess this comment might be out of date.
Yeah, it was the old version I forgot to update the description. |
seadowg
requested changes
Apr 15, 2024
grzesiek2010
force-pushed
the
COLLECT-6073
branch
3 times, most recently
from
74c8e40
to
87544ac
Compare
grzesiek2010
force-pushed
the
COLLECT-6073
branch
2 times, most recently
from
e043354
to
5dd63fb
Compare
grzesiek2010
force-pushed
the
COLLECT-6073
branch
from
5dd63fb
to
bfad220
Compare
Done. |
seadowg
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6072
Closes #6073
Closes #6075
Closes #6080
Why is this the best possible solution? Were any other approaches considered?
#6073 has been fixed in 24d2b99 - as we have discussed it doesn't make sense to mix
thousands-sepwithmasked(maskedshould win).#6072 and #6075 have been fixed in 6628186 by fixing setting inputtypes.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This should fix the issues we had with
textandnumberquestions with the newmaskedappearance. Please test the form attached below but also theAll question typesone to make suretextandnumberquestions without themaskedappearance work well.Do we need any specific form for testing your changes? If so, please attach one.
The form attached to #6008
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still pass