Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message in jr:requiredMsg is ignored if it contain only capital letters #281

Closed
mmarciniak90 opened this issue Mar 22, 2018 · 5 comments
Closed

Comments

@mmarciniak90
Copy link

Software versions

JavaRosa v2.8.1

Problem description

Message in jr:requiredMsg is ignored if it contain only capital letters

Steps to reproduce the problem

  1. Start a form with a required message
    attributes.xml.txt
  2. Swipe forward

Expected behavior

A custom message should be shown.

@grzesiek2010
Copy link
Member

@opendatakit-bot claim

@getodk-bot
Copy link
Member

getodk-bot commented Jun 15, 2018

Hello @grzesiek2010, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@grzesiek2010
Copy link
Member

grzesiek2010 commented Sep 26, 2023

This has nothing to do with the size of letters. requiredMsg does not seem to recognize raw strings:
jr:requiredMsg="abc"
it needs to be referenced using itext:
r:requiredMsg="jr:itext('/data/group/text2:jr:requiredMsg')"

I would say that there is no need to add support for raw string because both pyxform and ODK Build use itext but constraintMsg does support raw strings so there is inconsistency between those two types of errors.

@lognaturel should we:

  1. Support raw strings in requiredMsg
  2. Remove support for raw strings in constraintMsg
  3. Leave it as-is

Forms I've used for testing:
forms.zip

@lognaturel
Copy link
Member

That's a weird one!

The spec does say raw strings should be supported so it feels like ideally they would be. Do you have a sense of how big of a list it would be?

@grzesiek2010
Copy link
Member

Oh if it's in the spec it should be fixed so #731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants