Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding expiration returning and mintime checking for expiration #88

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

deregtd
Copy link
Contributor

@deregtd deregtd commented Jul 25, 2023

  • Added returning of expiration time from all of the login/token functions
  • Added new parameter of minimum time before expiring to refresh anyway to EnsureLoggedIn (everyone should think about this amount before passing it, so I'm okay with it being a breaking change)

* Added returning of expiration time from all of the login/token functions
* Added new parameter of minimum time before expiring to refresh anyway to EnsureLoggedIn (everyone should think about this amount before passing it, so I'm okay with it being a breaking change)
@deregtd deregtd requested review from a team, jaredallard and george-e-shaw-iv July 25, 2023 22:18
cli/login.go Outdated Show resolved Hide resolved
Co-authored-by: George Shaw <george.e.shaw.iv@outlook.com>
@deregtd deregtd merged commit be1b46e into main Jul 25, 2023
3 checks passed
@deregtd deregtd deleted the ddr/expirations branch July 25, 2023 22:29
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants