[Billing] Make vat percentage nullable in Receipt

Automatic commit for getparthenon/monorepo@a77bc30
getparthenon · May 1, 2024 · b3247a9 · b3247a9
1 parent 37ccc41
commit b3247a9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Billing/Entity/Receipt.php b/src/Billing/Entity/Receipt.php
@@ -56,7 +56,7 @@ class Receipt implements ReceiptInterface
 
     private int $vatTotal;
 
-    private float $vatPercentage;
+    private ?float $vatPercentage = null;
 
     private \DateTimeInterface $createdAt;
 
@@ -246,12 +246,12 @@ public function getSubTotalMoney(): Money
         return Money::ofMinor($this->subTotal, strtoupper($this->currency));
     }
 
-    public function getVatPercentage(): float
+    public function getVatPercentage(): ?float
     {
         return $this->vatPercentage;
     }
 
-    public function setVatPercentage(float $vatPercentage): void
+    public function setVatPercentage(?float $vatPercentage): void
     {
         $this->vatPercentage = $vatPercentage;
     }

diff --git a/src/Billing/Entity/ReceiptInterface.php b/src/Billing/Entity/ReceiptInterface.php
@@ -104,7 +104,7 @@ public function getVatTotalMoney(): Money;
 
     public function getSubTotalMoney(): Money;
 
-    public function getVatPercentage(): float;
+    public function getVatPercentage(): ?float;
 
-    public function setVatPercentage(float $vatPercentage): void;
+    public function setVatPercentage(?float $vatPercentage): void;
 }
diff --git a/src/Resources/config/doctrine-mapping/Billing/Receipt.orm.xml b/src/Resources/config/doctrine-mapping/Billing/Receipt.orm.xml
@@ -16,7 +16,7 @@
         <field name="subTotal" column="sub_total" type="integer" nullable="false" />
         <field name="vatTotal" column="vat_total" type="integer" nullable="false" />
         <field name="comment" column="comment" type="string" nullable="true" />
-        <field name="vatPercentage" column="vat_percentage" type="float" nullable="false" />
+        <field name="vatPercentage" column="vat_percentage" type="float" nullable="true" />
         <embedded name="billerAddress" class="Parthenon\Common\Address" />
         <embedded name="payeeAddress" class="Parthenon\Common\Address" />
         <many-to-many field="payments" target-entity="Parthenon\Billing\Entity\PaymentInterface">