Skip to content

Commit

Permalink
templates: Move comments to above patch
Browse files Browse the repository at this point in the history
It's much more likely that existing comments will affect the user's
actions, rather than the patch content itself, so put the comments
first.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
  • Loading branch information
jk-ozlabs authored and stephenfin committed Mar 29, 2016
1 parent 070c1f3 commit e073ca7
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions patchwork/templates/patchwork/patch.html
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,22 @@ <h2>Checks</h2>

{% for item in patch.commit_message %}
<h2>Commit Message</h2>
<div class="comment">
<div class="meta">
<span>{{ patch.submitter|personify:project }}</span>
<span class="pull-right">{{ patch.date }}</span>
</div>
<pre class="content">
{{ item|commentsyntax }}
</pre>
</div>
{% endfor %}

{% for item in patch.answers %}
{% if forloop.first %}
<h2>Comments</h2>
{% endif %}

<div class="comment">
<div class="meta">
<span>{{ item.submitter|personify:project }}</span>
Expand Down Expand Up @@ -224,20 +240,4 @@ <h2>
</div>
{% endif %}

{% for item in patch.answers %}
{% if forloop.first %}
<h2>Comments</h2>
{% endif %}

<div class="comment">
<div class="meta">
<span>{{ item.submitter|personify:project }}</span>
<span class="pull-right">{{ item.date }}</span>
</div>
<pre class="content">
{{ item|commentsyntax }}
</pre>
</div>
{% endfor %}

{% endblock %}

0 comments on commit e073ca7

Please sign in to comment.