Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A/R/T on cover letter should increment the counters of every patch #113

Open
ruscur opened this issue Aug 24, 2017 · 8 comments
Open

A/R/T on cover letter should increment the counters of every patch #113

ruscur opened this issue Aug 24, 2017 · 8 comments
Labels
enhancement

Comments

@ruscur
Copy link
Contributor

ruscur commented Aug 24, 2017

Let's say we have a 5 patch series with a cover letter. I review the whole series, and rather than sending 5 emails I send one, in reply to the cover letter with my ack or review. This is pretty commonplace from what I've seen. The author of the series was concerned that my ack/review wouldn't be easily visible from Patchwork, so the maintainer would be less likely to merge the series.

A/R/T in reply to the cover letter should increment the counters for every patch in the series, making sure that the counter doesn't get incremented twice if the same person also replies with an A/R/T on an individual patch for some reason.
@ajdlinux
Copy link
Collaborator

Apparently @mpe thinks this is a good idea

This shouldn't be too hard, I'll take a look when I get the chance

@borkmann
Copy link

borkmann commented Dec 6, 2017 •
edited
Loading

I think it would also be super useful when downloading the series with git-pw (for example) that those given Acked-by:'s from the cover letter could then all be automatically added to the individual patches of the series when applied.

Reason for this is that when organisations with maintaining custom downstream kernels (e.g. RHEL et al) would git cherry-pick those patches from the upstream git tree, then they would cherry-pick individual patches of the series, but not the merge itself, so the information on who gave an A/R/T/F tag is then lost when residing only in the cover-letter.

Having this automated in patchwork would be really useful.

veruu added a commit to veruu/patchwork that referenced this issue Mar 1, 2018
@veruu
Implementation of tagging for cover letters
7ebadc3 
Solves getpatchwork#113 and partially getpatchwork#57 GitHub issues.

* Change PatchTag to SubmissionTag to allow tagging of cover letters
* Make CoverLetter tags increase tag counts on all patches in the
  series

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Mar 6, 2018
@veruu
Rework tagging infrastructure
3b07631 
Solves getpatchwork#113 and getpatchwork#57 GitHub issues.

* Change PatchTag to SubmissionTag to allow tagging of cover letters
* Make CoverLetter tags increase tag counts on all patches in the
  series
* Allow storage of arbitrary string values with associated tags (this
  lets users know directly who acked or reviewed given patch, but also
  allows (for example) links to issue trackers as tags)
* Actually return tag values in the API

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Mar 6, 2018
@veruu
Rework tagging infrastructure
2f44365 
Solves getpatchwork#113 and getpatchwork#57 GitHub issues.

* Change PatchTag to SubmissionTag to allow tagging of cover letters
* Make CoverLetter tags increase tag counts on all patches in the
  series
* Allow storage of arbitrary string values with associated tags (this
  lets users know directly who acked or reviewed given patch, but also
  allows (for example) links to issue trackers as tags)
* Actually return tag values in the API

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Mar 16, 2018
@veruu
Rework tagging infrastructure
56aeff2 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, allow tags on comments, fix up
returning tags in the API.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Mar 27, 2018
@veruu
Rework tagging infrastructure
8328cd0 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, allow tags on comments, fix up
returning tags in the API.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Apr 19, 2018
@veruu
Rework tagging infrastructure
bcee7ae 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to later be able to add tags to comments in
the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue May 17, 2018
@veruu
Rework tagging infrastructure
0a2c823 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to later be able to add tags to comments in
the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue May 21, 2018
@veruu
Rework tagging infrastructure
92fb0ce 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to later be able to add tags to comments in
the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue May 21, 2018
@veruu
Rework tagging infrastructure
c85fc64 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to later be able to add tags to comments in
the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue May 21, 2018
@veruu
Rework tagging infrastructure
753fd83 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to later be able to add tags to comments in
the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue May 22, 2018
@veruu
Rework tagging infrastructure
84696a9 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to later be able to add tags to comments in
the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue May 25, 2018
@veruu
Rework tagging infrastructure
e41ec52 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to later be able to add tags to comments in
the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue May 25, 2018
@veruu
Rework tagging infrastructure
2b75540 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to later be able to add tags to comments in
the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Jun 20, 2018
@veruu
Rework tagging infrastructure
de0efe4 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to be able to add tags to comments in the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Jun 22, 2018
@veruu
Rework tagging infrastructure
ccf7d9d 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to be able to add tags to comments in the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Jun 23, 2018
@veruu
Rework tagging infrastructure
fb8065c 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to be able to add tags to comments in the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Jun 25, 2018
@veruu
Rework tagging infrastructure
89b1c93 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to be able to add tags to comments in the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Jul 9, 2018
@veruu
Rework tagging infrastructure
0a764b9 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to be able to add tags to comments in the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Jul 9, 2018
@veruu
Rework tagging infrastructure
a257ad4 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, fix up returning tags in the API,
keep track of tag origin to be able to add tags to comments in the API.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Sep 14, 2018
@veruu
Rework tagging infrastructure
739a0be 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, keep track of tag origin to be able
to add tags to comments in the API later.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Sep 14, 2018
@veruu
Rework tagging infrastructure
d401bfd 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, keep track of tag origin to be able
to add tags to comments in the API later.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Sep 20, 2018
@veruu
Rework tagging infrastructure
a9e0de7 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, keep track of tag origin to be able
to add tags to comments in the API later.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Sep 20, 2018
@veruu
Rework tagging infrastructure
2af34ef 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, keep track of tag origin to be able
to add tags to comments in the API later.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Sep 21, 2018
@veruu
Rework tagging infrastructure
493ae6f 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, keep track of tag origin to be able
to add tags to comments in the API later.

Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of
tags for each patch in series, and use `series` attribute of
SubmissionTag as a notion of a tag which is related to each patch in the
series (because it comes from cover letter or it's comments)

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Sep 21, 2018
@veruu
Rework tagging infrastructure
6caa719 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, keep track of tag origin to be able
to add tags to comments in the API later.

Tags are now related to series rather then patches. If the tag comes
from a cover letter, only the series field is set, if from a comment on
cover, both series and comment fields are set, if from a patch, series
and patch fields are set and if from a comment on a patch, all fields
are set.

Move functionality related to tag extraction into parser.py.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Sep 21, 2018
@veruu
Rework tagging infrastructure
83a5bf1 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, keep track of tag origin to be able
to add tags to comments in the API later.

Tags are now related to series rather then patches. If the tag comes
from a cover letter, only the series field is set, if from a comment on
cover, both series and comment fields are set, if from a patch, series
and patch fields are set and if from a comment on a patch, all fields
are set.

Move functionality related to tag extraction into parser.py.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
veruu added a commit to veruu/patchwork that referenced this issue Sep 21, 2018
@veruu
Rework tagging infrastructure
c44acd6 
Solve getpatchwork#113 and getpatchwork#57 GitHub issues, keep track of tag origin to be able
to add tags to comments in the API later.

Tags are now related to series rather then patches. If the tag comes
from a cover letter, only the series field is set, if from a comment on
cover, both series and comment fields are set, if from a patch, series
and patch fields are set and if from a comment on a patch, all fields
are set.

Move functionality related to tag extraction into parser.py.

Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
@borkmann
Copy link

@daxtens @veruu Any progress with A/R/T/F tag count propagation and automatic A/R/T/F appending to the individual patches from a series? Thanks

@daxtens
Copy link
Collaborator

daxtens commented Sep 27, 2019 via email

@alialnu
Copy link
Contributor

alialnu commented Dec 6, 2020

Hi,
Does anyone have progress on this? Any related changes in v2.2?

Thanks!

@stephenfin
Copy link
Member

Nothing in v2.2. It's still on my backlog but my time for Patchwork is very limited nowadays, unfortunately.

@nmenon
Copy link

nmenon commented Mar 18, 2022

bump?

@daxtens
Copy link
Collaborator

daxtens commented Mar 20, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@nmenon @borkmann @stephenfin @ajdlinux @daxtens @ruscur @alialnu