Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 author name corruption #194

Closed
torvalds opened this issue Jul 1, 2018 · 7 comments
Closed

UTF-8 author name corruption #194

torvalds opened this issue Jul 1, 2018 · 7 comments

Comments

@torvalds
Copy link

torvalds commented Jul 1, 2018

Apparently patchwork will corrupt author names, see for example

https://patchwork.kernel.org/patch/10431971/

which caused the author name to be reported as '???' in the kernel logs.

I can see the original email in my own mail queue, and it has

From:   =?big5?B?ufmxUrph?= <kt.liao@emc.com.tw>

in the headers, but patchwork has corrupted it to ??? not just in the web view, but also in the downloaded mbox file.

Please fix. We try very hard to accomodate non-US-ASCII names these days. That may not always have been the case, but utf-8 is a thing today. The only valid thing, in fact.

@torvalds
Copy link
Author

torvalds commented Jul 2, 2018

It looks like this may already be fixed in a newer version of patchwork.

Because when looking at

https://lore.kernel.org/patchwork/patch/909790/

the Chinese characters show up correctly.

@ajdlinux
Copy link
Collaborator

ajdlinux commented Jul 2, 2018

You're not the first to notice this: the report at https://patchwork.ozlabs.org/patch/430569/ dates from January 2015. kernel.org patchwork is so ancient it doesn't even print a version number in the footer.

Now that we've had some time to iron out the performance issues in patchwork 2.0 it's probably time for patchwork.kernel.org to get an upgrade to 2.1...

@mpe
Copy link
Contributor

mpe commented Jul 2, 2018

I'm fairly certain this is fixed in current patchwork.

For example this patch:
http://patchwork.ozlabs.org/patch/910062/

If you open the headers you see:
From: =?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>

I applied it from patchwork and the resulting commit is correct:
https://git.kernel.org/torvalds/c/282498d65fb4

@stephenfin
Copy link
Member

You're not the first to notice this: the report at patchwork.ozlabs.org/patch/430569 dates from January 2015. kernel.org patchwork is so ancient it doesn't even print a version number in the footer.

Now that we've had some time to iron out the performance issues in patchwork 2.0 it's probably time for patchwork.kernel.org to get an upgrade to 2.1...

Yup, this has been resolved since at least 1.0, iirc, though no single change jumped out at me as I looked through the logs.

At noted above, that version of patchwork is ancient and really needs to be updated to something a newer. Feel free to send people this way (or the the list if help is needed in doing so.

@stephenfin
Copy link
Member

(I was pretty sure patchwork.kernel.org was being superseded by lore.kernel.org/patchwork too. Maybe things have changed?)

@ajdlinux
Copy link
Collaborator

ajdlinux commented Jul 2, 2018

@stephenfin According to the page you linked, only the LKML project on pw.k.o is being deprecated - which makes sense given the other subsystem lists that are hosted on the k.o instance.

@stephenfin
Copy link
Member

@ajdlinux Ah, correct. My mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants