Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewed-by gets inserted in the wrong place #516

Closed
siddhesh opened this issue Jan 17, 2023 · 1 comment
Closed

Reviewed-by gets inserted in the wrong place #516

siddhesh opened this issue Jan 17, 2023 · 1 comment
Labels
bug

Comments

@siddhesh
Copy link
Contributor

For this patch[1], the resulting mbox[2] has the Reviewed-by in the wrong place. Here's the original email[3] for reference.

[1] https://patchwork.sourceware.org/project/glibc/patch/20230115183715.1278363-1-martin.joerg@gmail.com/
[2] https://patchwork.sourceware.org/project/glibc/patch/20230115183715.1278363-1-martin.joerg@gmail.com/mbox/
[3] https://sourceware.org/pipermail/libc-alpha/2023-January/144739.html
@siddhesh
Copy link
Contributor Author

cc @fweimer

@stephenfin stephenfin added the bug label Jan 24, 2023
stephenfin added a commit that referenced this issue Jan 25, 2023
@stephenfin
Correctly append tags on patches without commit details
f23e7fe 
Only a commit summary (a.k.a. patch subject) is necessary in Git: we
don't need details. The regex we were using to search for postscripts
however assumed that there would be _something_ before the postscript,
resulting in a newline. This wasn't the case. Correct this assumption by
instead using 're.MULTILINE' and matching on '^' and '$' for newlines
instead of '\n'.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Closes: #516
Cc: siddhesh@gotplt.org
(cherry picked from commit 05da32f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siddhesh @stephenfin