Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Issue #509 + #510] Series views #589

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

andrepapoti
Copy link

@andrepapoti andrepapoti commented Apr 23, 2024

Description

This PR adds a new series-list and series-detail view.
Some projects can have hundreds of patches actives at once, by giving the user the ability to have an overview of all of the series makes knowing what's the current state of a project much more simple.
Series-list also allows the user to apply changes to all of the patches of a determined series, making the management of them easier
Added navigation within a series for the patch-detail view

Related

This form is similar to the MultiplePatchForm but is meant to apply
chages to all of thje patches contained in a series.
bulk_update_patches() was also added to simplify applying changes to
multiple patches

Signed-off-by: andrepapoti <andrepapoti@gmail.com>
This view is meant to give a quickoverview on a project since some of
them can have hundreds of patches actives.
This view also allows the user to apply changes on all of the series
patches at once

Signed-off-by: andrepapoti <andrepapoti@gmail.com>
Signed-off-by: andrepapoti <andrepapoti@gmail.com>
Signed-off-by: andrepapoti <andrepapoti@gmail.com>
Signed-off-by: andrepapoti <andrepapoti@gmail.com>
Signed-off-by: andrepapoti <andrepapoti@gmail.com>
Signed-off-by: andrepapoti <andrepapoti@gmail.com>
@stephenfin
Copy link
Member

Sorry for the absurd delay getting to this: my free time for Patchwork is pretty much zero recently... 😅

I've taken a look at this locally but have yet to go into depth on it. There are two obvious issues starting out though. Firstly, you need to do some serious work on the queries: I loaded up the patchwork archives (following the guide in our development docs and loading the series-list page took over 7 seconds and ~3050 queries (:smile:). Secondly, the current iteration of the UI doesn't work and it scrolls past the edge of the screen. I would suggest the following changes:

  • Series Name should be the first column and called Series, as we do for patch list and Patch
  • Rather than showing cover letter text (expensive and, as things stand, rather ugly), show a unicode tick if there's a cover letter present.
  • Shorten Number of Patches to Patches
  • Get rid of the bulk update widget: it's too complicated to represent in a list view (IMO) and users can either click into the series to do that or use the API

Other changes:

  • /series/{series} should be /project/{project}/series/{series} to map with patches
  • /project/patchwork/series-list/ should be /project/patchwork/series/, and we should rename /project/patchwork/list/ to /project/patchwork/patches/ (with an alias in place).
  • We need a different icon for the series view link in the top toolbar (tbh, we also need a different icon for the patch view but that's not your issue)

This is rather beefy PR so if you have the ability to do, I'd suggest submitting v2 via the mailing list if you have the ability/know-how to do so. That'll be easier for me to review. Feel free to stick to GitHub if you can't/aren't comfortable using the mailing list though 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add patch navigation within a series Series view
2 participants