Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If multiple patches have the same hash, pwclient does not take any #31

Open
YasLbk opened this issue Jan 11, 2024 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@YasLbk
Copy link

YasLbk commented Jan 11, 2024

pwclient info -h 4a47f1233259930c1e9c532d8c5c0acbf2ae213b
No patch has the hash provided

git-pw patch list --hash 4a47f1233259930c1e9c532d8c5c0acbf2ae213b
+------+-------------+-----------------------------------------------------------------+----------------------------------------------+---------+------------+------------+
|   ID | Date        | Name                                                            | Submitter                                    | State   | Archived   | Delegate   |
|------+-------------+-----------------------------------------------------------------+----------------------------------------------+---------+------------+------------|
| 1928 | a week ago  | [v2,46/46] utils: merge  | jp (jxxxxxxx.com)                    | new     | no         |            |
| 4646 | 2 weeks ago | [45/45] utils: merge     | jp (jxxxxxxx..com)                   | new     | no         |            |
+------+-------------+-----------------------------------------------------------------+----------------------------------------------+---------+------------+------------+
@YasLbk YasLbk changed the title If multiple patches has the same hash, pwclient does not take any If multiple patches have the same hash, pwclient does not take any Jan 11, 2024
@stephenfin
Copy link
Member

stephenfin commented Jan 16, 2024

This is unfortunately necessary to ensure behaviour is consistent between the XML-RPC API backend and the REST API backend, as you can see here (the XML-RPC API will not return anything if it finds more than one patch matching a hash). We can change this but it's going to need a release note.

@stephenfin stephenfin added enhancement New feature or request good first issue Good for newcomers labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants