Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-ASCII character in README #18

Closed
wants to merge 1 commit into from

Conversation

neirbowj
Copy link
Contributor

@neirbowj neirbowj commented Jul 27, 2020

This patch enables running setup.py in environments in which locale.getpreferredencoding(False) returns 'ASCII' or any ASCII-compatible encoding.

Fixes #19

@justinmayer
Copy link
Member

While I think the word "gratuitous" here is unnecessarily judgmental, I'm happy to entertain a more detailed description of the types of environments where the proper apostrophe poses a problem, as well as a more detailed description of what said problem is.

@neirbowj neirbowj changed the title Replace gratuitous non-ASCII character in README Replace non-ASCII character in README Jul 28, 2020
@neirbowj
Copy link
Contributor Author

Thank you for that feedback. I have removed the objectionable word and will open a corresponding bug report to which this PR could become a candidate resolution.

@neirbowj
Copy link
Contributor Author

An arguably superior alternative, which some other projects have adopted, would be to explicitly pass the encoding parameter to open. To retain backward compatibility with Python 2, it has to be passed conditionally, e.g. via **kwargs.

@avaris
Copy link
Member

avaris commented Jul 29, 2020

An arguably superior alternative, which some other projects have adopted, would be to explicitly pass the encoding parameter to open.

Yes, let's do that please.

To retain backward compatibility with Python 2, it has to be passed conditionally, e.g. via **kwargs.

from io import open

then you can use encoding in both python2 and python3

@neirbowj
Copy link
Contributor Author

neirbowj commented Jul 29, 2020

@avaris Great tip! See competing PR in #20.

@justinmayer
Copy link
Member

Closing in favor of #20, which has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup.py fails with UnicodeDecodeError on FreeBSD 12.1-RELEASE-p6 under poudriere
3 participants