Assets: Allow to explicitly set debug mode #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to explicitly set debug mode instead of relying on the logger. Running `--debug` in pelican only changes the logging so it can be used in production however with this using the logger to change how assets work I can no longer use it in production (which is needed for other reasons). So this change is to allow more control. I haven't tested or anything, about to make the change myself and use it. However adding code here should easily show you what I mean if you want to implement it a different way.
robclancy
changed the title
|
This single repository for all these plugins is a terrible idea. I'll just fork this instead like I have had to do with others because of this bizarre setup. |
|
We have already acknowledged that this could (and will) be improved, as noted in #39. |
justinmayer
added a commit
that referenced
this pull request
Jan 28, 2015
Assets: Allow to explicitly set debug mode
|
Thank you. On Thu, Jan 29, 2015 at 3:34 AM, Justin Mayer notifications@github.com
|
calfzhou
pushed a commit
to calfzhou/pelican-plugins
that referenced
this pull request
Sep 28, 2019
docs(changelog): update change log for next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to explicitly set debug mode instead of relying on the logger. Running
--debugin pelican only changes the logging so it can be used in production however with this using the logger to change how assets work I can no longer use it in production (which is needed for other reasons). So this change is to allow more control.I haven't tested or anything, about to make the change myself and use it. However adding code here should easily show you what I mean if you want to implement it a different way.