Skip to content

Commit

Permalink
Merge pull request #2610 from MinchinWeb/default-status
Browse files Browse the repository at this point in the history
Set default content status to blank string instead of `None`
  • Loading branch information
justinmayer committed Aug 21, 2019
2 parents 7c2a747 + b2da535 commit 99ea502
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
7 changes: 7 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Release type: patch

Set default content status to a blank string rather than `None`. Fixes
[#2558](https://github.com/getpelican/pelican/issues/2558). Fixes issues
encountered by comment plugins among others
([1](https://github.com/bstpierre/pelican-comments/pull/4),
[2](https://github.com/Scheirle/pelican_comment_system/issues/8)).
4 changes: 3 additions & 1 deletion pelican/contents.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ def __init__(self, content, metadata=None, settings=None,

# manage status
if not hasattr(self, 'status'):
self.status = getattr(self, 'default_status', None)
# using None as the default here breaks comment plugins (and
# probably others)
self.status = getattr(self, 'default_status', '')

# store the summary metadata if it is set
if 'summary' in metadata:
Expand Down

0 comments on commit 99ea502

Please sign in to comment.