Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty slug causes generation of hidden file #1469

Closed
foresto opened this issue Sep 18, 2014 · 5 comments
Closed

Empty slug causes generation of hidden file #1469

foresto opened this issue Sep 18, 2014 · 5 comments

Comments

@foresto
Copy link
Contributor

foresto commented Sep 18, 2014

Having this line in my markdown source:

Slug:

Causes pelican to generate a file called .html in the output directory. Being a "dot file", it is hidden on unix-like systems, and probably not something that anyone wants. I think it would make more sense to behave as if there was no Slug: line at all.

@justinmayer
Copy link
Member

@foresto: I agree. Is this something you would like to help us fix?

@foresto
Copy link
Contributor Author

foresto commented Sep 27, 2014

Yes, I think I can manage that.

Looking through readers.py and contents.py, I see there are several other metadata that are treated as present even if they are empty. Maybe I should fix them all. Should empty strings be considered valid for any of them?

@foresto
Copy link
Contributor Author

foresto commented Oct 5, 2014

See also: #1398.

@foresto
Copy link
Contributor Author

foresto commented Oct 7, 2014

Sorry about all the commit noise. Fixing this without breaking something else turned out to be trickier than I expected, and git's downright hostile UI and documentation have made learning it something of an exercise in trial and error.

In any case, I believe my latest commit does the job. There's a detailed explanation in pull request #1491.

@foresto
Copy link
Contributor Author

foresto commented Nov 1, 2014

Also, I think it's safe to remove the awaiting user feedback tag. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants