Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typogrifying objects without title #1964

Merged
merged 1 commit into from Jul 18, 2016
Merged

Fix typogrifying objects without title #1964

merged 1 commit into from Jul 18, 2016

Conversation

rr-
Copy link
Contributor

@rr- rr- commented May 28, 2016

This fixes my use case where I use readers.read_file from within a plugin to load something that is neither a page nor an article and it makes little sense for it to have a title, but it has metadata and content that should be parsed like the rest of the objects.

@iKevinY
Copy link
Member

iKevinY commented May 28, 2016

Looks fine to me. Maybe even pull it out of the if content block so that all 3 of the conditionals are independent from one another?

This fixes my use case where I use `readers.read_file` from within plugin to load something that is neither a page nor an article.
@rr-
Copy link
Contributor Author

rr- commented May 29, 2016

Fixed

@Scheirle
Copy link
Member

The pelican_comment_system also needs this fix. It uses readers.read_file on comments which don't have a title.

I didn't run into this error earlier since I don't use typogrify.


👍

@rr-
Copy link
Contributor Author

rr- commented Jul 18, 2016

Status?

@justinmayer justinmayer added this to the 3.7 milestone Jul 18, 2016
@justinmayer
Copy link
Member

Apologies for the delay. Thanks to @rr- for the fix and to @iKevinY and @Scheirle for reviewing. (^_^)

@justinmayer justinmayer merged commit 6232241 into getpelican:master Jul 18, 2016
@rr-
Copy link
Contributor Author

rr- commented Jul 18, 2016

Thanks :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants