Set setup.py open file encoding to UTF-8 #2067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package building environments usually differ with a working environment where locale settings are tricky. This change enforce using UTF-8 to open files in setup.py in order to avoid possible encoding errors when reading README and changelog files when they contain non-ASCII chars.
Use open in io for encoding under python2
|
Many thanks for the fix, Jiachen. We didn't notice this until after #2082 was merged. Nonetheless, we really appreciate your help! (^_^) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package building environments usually differ with a working environment
where locale settings are tricky. This change enforce using UTF-8 to
open files in setup.py in order to avoid possible encoding errors when
reading README and changelog files when they contain non-ASCII chars.