Add Python 3.6 test environment #2094
Conversation
* Add py36 environment to tox * Unify dependencies across manual installation and tox * Mention tox in the docs
ingwinlu
force-pushed
the
add_test_unknown_file
branch
from
2f73cfb
to
5ca19ee
Compare
There was no test case checking the behaviour of what happens when
trying to {filename} an unknown file.
Also changed the braces to `'` chars that we use elseware.
ingwinlu
force-pushed
the
add_test_unknown_file
branch
from
5ca19ee
to
22208a9
Compare
|
@getpelican/reviewers go for review :) |
docs/contribute.rst
Outdated
| @@ -47,13 +47,16 @@ Or using ``pip``:: | |||
|
|
|||
| $ pip install -e . | |||
|
|
|||
| To conveniently test vs multiple python versions we also provide a tox file. | |||
There was a problem hiding this comment.
To conveniently test on multiple Python versions, we also provide a
.toxfile.
.travis.yml
Outdated
| include: | ||
| - python: 3.6 | ||
| env: | ||
| - TOX_ENV=py36 |
There was a problem hiding this comment.
It would probably be better to keep indentation here consistent with the rest of the file (2 spaces).
| @@ -37,8 +37,7 @@ import-order-style = cryptography | |||
| [testenv:flake8] | |||
| basepython = python2.7 | |||
| deps = | |||
| flake8 <= 2.4.1 | |||
| git+https://github.com/public/flake8-import-order@2ac7052a4e02b4a8a0125a106d87465a3b9fd688 | |||
There was a problem hiding this comment.
Just confirming: we don't need to pin flake8-import-order to this commit anymore?
There was a problem hiding this comment.
yes
Back when i added the environment with the flake8 check there was a bug with one of the rules which was fixed in the repo, but not in the release.
|
Updated with review-feedback |
.travis.yml
Outdated
| include: | ||
| - python: 3.6 | ||
| env: | ||
| - TOX_ENV=py36 |
There was a problem hiding this comment.
There's still some indentation that has snuck in here 😛 (basically just remove the spaces that show up in the diff on lines 12-15)
There was a problem hiding this comment.
Ah the good old 'let me just commit this real quick before bed' strikes again...
ingwinlu
force-pushed
the
add_test_unknown_file
branch
from
7c2c5e8
to
d6ffdcd
Compare
* improve wording on testing with fox (contribute.rst) * fix whitespace (.travis.xml)
ingwinlu
force-pushed
the
add_test_unknown_file
branch
from
d6ffdcd
to
490e364
Compare
justinmayer
changed the title
See commits.